Rewritten Engine's terminate and terminate_epoch logic#2645
Merged
vfdev-5 merged 13 commits intopytorch:masterfrom Aug 23, 2022
Merged
Rewritten Engine's terminate and terminate_epoch logic#2645vfdev-5 merged 13 commits intopytorch:masterfrom
vfdev-5 merged 13 commits intopytorch:masterfrom
Conversation
…xception - terminate_epoch work on iteration-based events, called on catched _EngineTerminateSingleEpochExpection - Fixed issue when attaching handlers on Events.TERMINATE_SINGLE_EPOCH
vfdev-5
commented
Aug 16, 2022
Collaborator
Author
|
@sadra-barikbin do you have any other remarks for this PR that could be blocking it for being merged ? |
Collaborator
I finalize my review in a few minutes. |
Collaborator
Author
@sadra-barikbin have you submitted your review ? |
vfdev-5
force-pushed
the
rewrite-engine-terminate-and-co
branch
from
20ee6a9 to
d350ff5
Compare
Collaborator
Author
|
@sadra-barikbin I updated the docs and tests etc. Please review it again. I want to merge it by tomorrow. Thanks |
sadra-barikbin
approved these changes
Aug 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Check list:
@sadra-barikbin can you please review and comment out what do you think ?